Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current setup seem to require that
satclip
be on a customized$PYTHONPATH
, for example with:Moreover, it does not list dependencies and versioning (see Issue Missing requirements.txt file #8)
This PR proposes to setup
satclip
as a Python package to install it just like any other Python package, and facilitating its use from any directory, without the need to setup thePYTHONPATH
.Usage:
pip install .
Example use cases:
SatCLIP
PyTorch model:from satclip.model import SatCLIP
satclip
in different training scriptsfrom satclip.location_encoder import LocationEncoder
or againfrom satclip.main import SatCLIPLightningModule
PR changes
pyproject.toml
using setuptools as a build system, following the latest recommendations from Python packagingsatclip
package directoryTesting
pip install .
runs succesfullysatclip
from any folder, without setting$PYTHONPATH
:Example log output (click to expand)
Log from pip install .