-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint sarif formatter improvements #2458
Conversation
The fix resolved below vulnerable packages issue reported by Github. Note the first alert is for src/TypeScript/Sarif.SDK/package-lock.json, it needs a separated fix. |
Workflow platform 'windows-latest' upgraded to windows 2022, but CodeQL doesn't support win11/win 2022. Have to specify explicitly windows-2019.
This reverts commit 7757e4b.
@marmegh and @EasyRhinoMSFT , we need to start getting more eyes on SARIF formatting work. @colawton docs/user-facing output will be a prominent part of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be late to reviewing this. We've moved the source to the We should determine a plan to:
This should not break/interrupt consumers, since the packages will be functionally the same. |
Hi @scalvert , Yong just created a PR moving the code. |
I saw that, which is what prompted me to write my comment. I've also commented on @yongyan-gh's PR in that repo. Thanks! |
Descriptions
Some improvements for ESLint SARIF formatter: