-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing AnalyzeCommandBase
and MultithreadedAnalyzeCommandBase
artifacts generation
#2433
Merged
michaelcfanning
merged 16 commits into
main
from
users/ednakamu/fixing-multithreaded-artifacts
Jan 31, 2022
+162
−106
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2247cbe
Fixing multithreaded artifacts generation
eddynaka 6972472
Fixing tests and flags
eddynaka 5d87498
Loosing precision.
eddynaka af33d03
Applying fix for AnalyzeCommandBase
eddynaka 3869b86
Enabling tests
eddynaka 70dffb5
Updating test case and release history
eddynaka 171133f
Creating const to prevent magical numbers everywhere
eddynaka d322ee4
Rebaselining tests
eddynaka e800ead
Merge branch 'users/ednakamu/rebaselining-files' into users/ednakamu/…
eddynaka fd9bd16
Creating Artifacts flag to keep previous behavior
eddynaka 6996260
Addressing PR feedback.
eddynaka 8a78dd8
Rollback changes
eddynaka 44eb8d2
Update SARIF2012.ProvideRuleProperties_Invalid.sarif
eddynaka cabbd5f
updating back
eddynaka a3408b3
Ordering deprecated names
eddynaka dbaae40
Merge branch 'users/ednakamu/fixing-multithreaded-artifacts' of https…
eddynaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing tests and flags
commit 6972472ac49ff5c2b5da1fea05aaaed3db6add98
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should only persist if: