Enable automation details for command base #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,6 +220,14 @@ public bool ShouldSerializeGraphs() | |||
| return this.Graphs.HasAtLeastOneNonDefaultValue(Graph.ValueComparer); | |||
| } | |||
|
|
|||
| public bool ShouldSerializeAutomationDetails() | |||
| { | |||
| return this.AutomationDetails?.Description != null || | |||
There was a problem hiding this comment.
The Description isn't a string, it is a Message type. It's why I didn't change to IsNullOrWhiteSpace check
| /// </summary> | ||
| public partial class RunAutomationDetails | ||
| { | ||
| public bool ShouldSerializeDescription() => this.Description != null; |
There was a problem hiding this comment.
The Description isn't a string, it is a Message type. It's why I didn't change to IsNullOrWhiteSpace check
| public string BaselineSarifFile { get; set; } | ||
|
|
||
| [Option( | ||
| "automationId", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imagine SARIF Pattern Matcher being run by someone, and we want to automatically ingest the output SARIF somehow.
With this, we could ask the user to run SARIF Pattern Matcher and pass
--automationIdand--automationGuid, that information would be stored in the SARIF and we would know that the SARIF was generated by a specific team.Follow-up change
Change the
commandBaseto accept a URI and this URI will be used to send the generated SARIF to that endpoint.cc: @cfaucon