Enable suppress command in the multitool #2394
Conversation
| valid &= options.ExpiryInDays >= 0; | ||
| valid &= !string.IsNullOrWhiteSpace(options.Justification); | ||
| valid &= (options.Status == SuppressionStatus.Accepted || options.Status == SuppressionStatus.UnderReview); | ||
| valid &= DriverUtilities.ReportWhetherOutputFileCanBeCreated(options.OutputFilePath, options.Force, FileSystem); |
There was a problem hiding this comment.
Even if every other item is false, this will return true if the last line is true, is this intended behavior?
Conversely, if every other item is true, this will return false if the last item is false. I can see why that might be useful in this case, but again, is that intended behavior? #Resolved
There was a problem hiding this comment.
I improved the tests.
it will only return true if all are true.
| if (timestamps) | ||
| { | ||
| //suppression.SetProperty("timeUtc", timeUtc.ToString(SarifUtilities.SarifDateTimeFormatMillisecondsPrecision, | ||
| // CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
do we still need this comment #Closed
There was a problem hiding this comment.
no we don't.
just removed!
thanks!
| { | ||
| //suppression.SetProperty("timeUtc", timeUtc.ToString(SarifUtilities.SarifDateTimeFormatMillisecondsPrecision, | ||
| // CultureInfo.InvariantCulture)); | ||
| suppression.SetProperty("timeUtc", timeUtc); |
There was a problem hiding this comment.
actually, they will be printed in the same format.
just improved the code below.
|
|
||
| if (expiryInDays > 0) | ||
| { | ||
| suppression.SetProperty("expiryUtc", expiryUtc.ToString(SarifUtilities.SarifDateTimeFormatMillisecondsPrecision, |
There was a problem hiding this comment.
just updated!
thanks
|
|
||
| if (!string.IsNullOrWhiteSpace(alias)) | ||
| { | ||
| suppression.SetProperty(nameof(alias), alias); |
There was a problem hiding this comment.
it will be stored in the property bag
| [Option( | ||
| "alias", | ||
| HelpText = "The account name associated with the suppression.")] | ||
| public string Alias { get; set; } |
There was a problem hiding this comment.
good question.
not sure yet the answer.
let's keep this way and we can improve in another iteration.
| } | ||
|
|
||
| w.Stop(); | ||
| Console.WriteLine($"Supress completed in {w.Elapsed}."); |
There was a problem hiding this comment.
like the idea to capture the execution time, not all commands implemented this, maybe we can move it to command base to work for all commands? #WontFix
There was a problem hiding this comment.
we can create an issue to improve this.
won't do this in this PR.
but good suggestion.
docs/multitool-usage.md
Outdated
| @@ -60,6 +61,9 @@ Sarif.Multitool merge C:\Input\*.sarif --recurse --output-directory=C:\Output\ - | |||
| : Extract new Results only from New Baseline | |||
| Sarif.Multitool query NewBaseline.sarif --expression "BaselineState == 'New'" --output Current.NewResults.sarif | |||
|
|
|||
| : Suppress Results | |||
| Sarif.Multitool suppress current.sarif --justification "some justification" --alias "some alias" --guids --timestamps --expiryInDays 5 --output suppressed.sarif | |||
No description provided.