Address object in location (and other nodes) : https://github.com/oasis-tcs/sarif-spec/issues/302 #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harleenkohli
changed the title
src/Sarif/Schemata/sarif-schema.json
Outdated
| "uniqueItems": false, | ||
| "default": [], | ||
| "items": { | ||
| "$ref": "#/definitions/address" |
There was a problem hiding this comment.
address [](start = 47, length = 7)
make this externalPropertyFile #Resolved
src/Sarif/Schemata/sarif-schema.json
Outdated
| @@ -560,6 +596,17 @@ | |||
| } | |||
| }, | |||
|
|
|||
| "addresses": { | |||
| "description": "The addresses associated with external property files, if any.", | |||
There was a problem hiding this comment.
The addresses associated with external property files, if any. [](start = 36, length = 62)
This s/be
"An array of external property files containing run.addresses arrays to be merged with the root log file." #Resolved
src/Sarif/Schemata/sarif-schema.json
Outdated
| @@ -1947,6 +1999,17 @@ | |||
| } | |||
| }, | |||
|
|
|||
| "addresses": { | |||
| "description": "The addresses associated with this run instance, if any.", | |||
There was a problem hiding this comment.
The addresses [](start = 36, length = 13)
Just say "Addresses associated..." #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.