Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SarifLogBaseliner does not populate firstDetectionTimeUtc #1737

Closed
ghost opened this issue Jan 28, 2020 · 0 comments
Closed

SarifLogBaseliner does not populate firstDetectionTimeUtc #1737

ghost opened this issue Jan 28, 2020 · 0 comments
Labels
area-baselining bug resolved-fixed

Comments

@ghost
Copy link

ghost commented Jan 28, 2020

No description provided.

@ghost ghost self-assigned this Jan 28, 2020
ghost pushed a commit that referenced this issue Jan 28, 2020
Fix #1737: SarifLogBaseliner does not populate firstDetectionTimeUtc
f9ab9be 
Previously, the code just asked whether or not a result from the current log matched a result in the baseline. Now, we actually extract the matching result from the baseline so we can roll its first detection time forward. If the matching result has no first detection time, we fall back to the time that the run was performed. And if we can't find that, we fall back to "now" as the first detection time.
@ghost ghost added the resolved-fixed label Jan 29, 2020
@ghost ghost closed this as completed Jan 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-baselining bug resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants