You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While fixing #1570, I noticed that after I caused the FxCop converter to emit run.logicalLocations, it didn't cause any tests to fail. It seems that there were no FxCop xml files with logical location information. How was that possible?
It turned out that there was one such file, SarifSdkTest.xml. But its corresponding expected output file SarifSdkTest.xml.sarif did contain run.logicalLocations, even though the converter wasn't emitting it. Therefore that file must have been created at a time when the converter did emit run.logicalLocations, and there was a subsequent regression where that functionality was lost.
Ok, fine, so why was the test passing before I made the fix?
It's because the test wasn't running, and that's because, even though the project file copied the expected output file to the test bin directory, it did not copy the input file.
When I enable the test by adding SarifSdkTest.xml to the project file, it fails. I don't completely understand why.
The text was updated successfully, but these errors were encountered:
While fixing #1570, I noticed that after I caused the FxCop converter to emit
run.logicalLocations
, it didn't cause any tests to fail. It seems that there were no FxCop xml files with logical location information. How was that possible?It turned out that there was one such file, SarifSdkTest.xml. But its corresponding expected output file SarifSdkTest.xml.sarif did contain
run.logicalLocations
, even though the converter wasn't emitting it. Therefore that file must have been created at a time when the converter did emitrun.logicalLocations
, and there was a subsequent regression where that functionality was lost.Ok, fine, so why was the test passing before I made the fix?
It's because the test wasn't running, and that's because, even though the project file copied the expected output file to the test bin directory, it did not copy the input file.
When I enable the test by adding SarifSdkTest.xml to the project file, it fails. I don't completely understand why.
The text was updated successfully, but these errors were encountered: