Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FxCop converter produces logicalLocation.index but not run.logicalLocations #1571

Closed
ghost opened this issue Jul 11, 2019 · 0 comments
Closed

FxCop converter produces logicalLocation.index but not run.logicalLocations #1571

ghost opened this issue Jul 11, 2019 · 0 comments
Labels
bug m156 resolved-fixed

Comments

@ghost
Copy link

ghost commented Jul 11, 2019

@harleenkohli discovered an FxCop SARIF file where theResult.locations[0].logicalLocations[0].index was populated, but theRun.logicalLocations was absent. This is invalid by §3.33.3:

If thisObject is an element of theRun.logicalLocations, then index MAY be present. ...

Otherwise, if theRun.logicalLocations is absent, or if it does not contain a cached object for thisObject, then index SHALL NOT be present.
@ghost ghost added the bug label Jul 11, 2019
@ghost ghost self-assigned this Jul 11, 2019
ghost pushed a commit that referenced this issue Jul 11, 2019
Fix #1571: FxCop converter doesn't emit logical locations.
c3c7586
@ghost ghost closed this as completed in 4ac33df Aug 9, 2019
@ghost ghost added the resolved-fixed label Aug 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug m156 resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning