-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Integrate phased builds with VS Code #3651
Draft
dmichon-msft
wants to merge
62
commits into
microsoft:main
Choose a base branch
from
dmichon-msft:vscode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2023
This was referenced Mar 23, 2024
This was referenced May 13, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exploratory hack project to control a phased Rush build from a VS Code extension and present the developer with the current build states of all phases in all requested projects.
Should ideally be combined with #3162, as the objectives are orthogonal
Details
Provides a VSCode panel that allows the developer to select one or more Rush projects as in scope, and trigger a worker thread that will watch for file saves and perform incremental phased rush builds, reporting the status of all operations to the UX.
How it was tested
rush build -T vscode-extension
Invoke
npm run watch
inapps/vscode-extension
Run the provided VSCode launch configuration option
Set
"rush.useWorkspaceRushVersion": false
in VSCode settings in the launched extension host window.Ensure that the workspace being tested in is configured to allow the version of node that VSCode is running in
Reload the window (Ctrl+R)
Open the Rush tab