Rename property

microsoft · May 18, 2021 · ace7a88 · ace7a88
1 parent d7a0e15
commit ace7a88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/common/changes/@rushstack/node-core-library/json-file-undefined_2021-05-13-21-25.json b/common/changes/@rushstack/node-core-library/json-file-undefined_2021-05-13-21-25.json
@@ -2,7 +2,7 @@
   "changes": [
     {
       "packageName": "@rushstack/node-core-library",
-      "comment": "Add `dropUndefinedValues` option to JSONFile to discard keys with undefined values during serialization, i.e. the standard behavior of JSON.stringify() and other JSON serializers.",
+      "comment": "Add `ignoreUndefinedValues` option to JSONFile to discard keys with undefined values during serialization, i.e. the standard behavior of JSON.stringify() and other JSON serializers.",
       "type": "minor"
     }
   ],

diff --git a/libraries/node-core-library/src/JsonFile.ts b/libraries/node-core-library/src/JsonFile.ts
@@ -53,7 +53,7 @@ export interface IJsonFileStringifyOptions {
    * If true, conforms to the standard behavior of JSON.stringify() when a property has the value `undefined`.
    * Specifically, the key will be dropped from the emitted object.
    */
-  dropUndefinedValues?: boolean;
+  ignoreUndefinedValues?: boolean;
 
   /**
    * If true, then the "jju" library will be used to improve the text formatting.
@@ -236,7 +236,7 @@ export class JsonFile {
       options = {};
     }
 
-    if (!options.dropUndefinedValues) {
+    if (!options.ignoreUndefinedValues) {
       // Standard handling of `undefined` in JSON stringification is to discard the key.
       JsonFile.validateNoUndefinedMembers(newJsonObject);
     }

diff --git a/libraries/node-core-library/src/test/JsonFile.test.ts b/libraries/node-core-library/src/test/JsonFile.test.ts
@@ -32,7 +32,7 @@ describe('JsonFile tests', () => {
       JsonFile.stringify(
         { abc: undefined },
         {
-          dropUndefinedValues: true
+          ignoreUndefinedValues: true
         }
       )
     ).toMatchSnapshot();
@@ -41,7 +41,7 @@ describe('JsonFile tests', () => {
       JsonFile.stringify(
         { abc: undefined },
         {
-          dropUndefinedValues: true,
+          ignoreUndefinedValues: true,
           prettyFormatting: true
         }
       )