Select image with keyboard #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1 and
vinguyen12
JiuqingSong
reviewed
Feb 18, 2025
| selection.focusOffset != range.endOffset, | ||
| }); | ||
| } else if (newSelection?.type !== 'image' && image) { | ||
| this.editor.setDOMSelection({ |
There was a problem hiding this comment.
Question, if I select text+image, will it also trigger the event?
There was a problem hiding this comment.
It should not trigger, the isSingleImageInSelection function verifies if there is only an image in the range selection. So, the image will be selected only if there only one image and no text or other element.
JiuqingSong
approved these changes
Feb 18, 2025
BryanValverdeU
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there were no image selected, and the selection changed to a single image, select the image as image selection.