[Mobile/Tablet] Make image edit features work with touch #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
| @@ -420,6 +420,7 @@ export class ImageEditPlugin implements ImageEditor, EditorPlugin { | |||
| if (this.imageEditInfo) { | |||
| this.startEditing(editor, image, ['resize', 'rotate']); | |||
| if (this.selectedImage && this.imageEditInfo && this.wrapper && this.clonedImage) { | |||
| const isMobileOrTable = !!editor.getEnvironment().isMobileOrTablet; | |||
There was a problem hiding this comment.
Should we also support it for normal PC? Since there are some with touch screens
BryanValverdeU
approved these changes
Oct 11, 2024
juliaroldi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable resize/rotate/crop images using touch events.
