Fix #2804 adjustLinkSelection does not select whole link #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
requested review from
flyingbee2012,
BryanValverdeU,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
juliaroldi
approved these changes
Oct 4, 2024
BryanValverdeU
added a commit
that referenced
this pull request
Oct 11, 2024
* Add a ID to the TempDiv, to be able to identify on blur was caused for copy/cut #2813 * delete image range * remove selection * fix build * WIP * clean info when delete image * WIP * WIP * add unit tests * nit * Remove style "white-space" from empty paragraph (#2820) * Remove white-space style for empty paragraph * improve * Fix #2804 (#2821) * touch images * Do not treat image without src as empty image (#2823) * update versions.json * update versions --------- Co-authored-by: Julia Roldi (from Dev Box) <[email protected]> Co-authored-by: Julia Roldi <[email protected]> Co-authored-by: Jiuqing Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2804
This is because when cache is enabled, the updated selection marker does not copy link info from text segment, so
adjustLinkSelectionfailed to match the text segment around the selection marker.Fix: Include link and code info in reconciled selection marker.