Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paste code to add a paragraph when the clipboard contains atleast a block element #2777

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

BryanValverdeU
Copy link
Contributor

@BryanValverdeU BryanValverdeU commented Aug 26, 2024

Update current paste behavior depending whether the clipboard content contains a block element.

  1. If the clipboard contains a block, add an additional paragraph after the paste content. And this additional block, should have the format before the paste.
  2. If the clipboard content contains only inline elements, we will not add an additional paragraph, however we will update the pending format, so we do not use the format before the paste and instead we use the format from the clipboard.

Inline Before
InlineBefore

Inline After
InlineAfter

Block Before
blockBefore

Block After
blockAfter

@BryanValverdeU BryanValverdeU changed the title Update paste code to add a paragraph when the clipboard contains atleast a clipboard Update paste code to add a paragraph when the clipboard contains atleast a block element Aug 26, 2024
@BryanValverdeU BryanValverdeU merged commit f496042 into master Sep 4, 2024
7 checks passed
JiuqingSong added a commit that referenced this pull request Sep 6, 2024
* image-selection

* fixes

* safari fix

* fix drag and drop

* fixes

* fixes

* Add `<del>` elements to default processors and use knownElementProcessor for this type of element. (#2770)

* init

* Use alphabet order

* Dont remove the MarginTop/Bottom from lists when pasting from Word Online (#2778)

* init

* remove unneeded function

* try fix build

* Reconcile table and image selection for cache (#2714)

* Improve cache

* fix build

* improve

* add test

* Cache and entity 2

* Add test

* Reconcile table and image selection for cache

* support reconcile entity delimiter

* fix build

* add test

---------

Co-authored-by: Bryan Valverde U <[email protected]>

* Set segmentFormat text color to black when creating the model of the clipboard content and using Keep source formatting paste type (#2773)

* init

* add a link to tests and make sure it is handled correctly

* fixes image in tables

* Bump webpack from 5.84.1 to 5.94.0 (#2780)

Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.84.1...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Resolve null sheet in convertInlineCss (#2784)

* init

* update

* Update paste code to add a paragraph when the clipboard contains atleast a block element (#2777)

* init

* add a link to tests and make sure it is handled correctly

* init

* try fix build

* fix build

* Fix 300391: [Mail] The numbers will become a continuous sequence after typing enter at the last line of the numbering above (#2782)

Co-authored-by: Bryan Valverde U <[email protected]>

* Pressing Tab inside a table should select all node contents of the next cell (#2764)

* normalise position

* revert

* empty cell check

* select using children

* fix tests

* fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Julia Roldi (from Dev Box) <[email protected]>
Co-authored-by: Julia Roldi <[email protected]>
Co-authored-by: Bryan Valverde U <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andres-CT98 <[email protected]>
JiuqingSong added a commit that referenced this pull request Sep 6, 2024
* image-selection

* fixes

* safari fix

* fix drag and drop

* fixes

* fixes

* Add `<del>` elements to default processors and use knownElementProcessor for this type of element. (#2770)

* init

* Use alphabet order

* Dont remove the MarginTop/Bottom from lists when pasting from Word Online (#2778)

* init

* remove unneeded function

* try fix build

* Reconcile table and image selection for cache (#2714)

* Improve cache

* fix build

* improve

* add test

* Cache and entity 2

* Add test

* Reconcile table and image selection for cache

* support reconcile entity delimiter

* fix build

* add test

---------

Co-authored-by: Bryan Valverde U <[email protected]>

* Set segmentFormat text color to black when creating the model of the clipboard content and using Keep source formatting paste type (#2773)

* init

* add a link to tests and make sure it is handled correctly

* fixes image in tables

* Bump webpack from 5.84.1 to 5.94.0 (#2780)

Bumps [webpack](https://github.com/webpack/webpack) from 5.84.1 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.84.1...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Resolve null sheet in convertInlineCss (#2784)

* init

* update

* Update paste code to add a paragraph when the clipboard contains atleast a block element (#2777)

* init

* add a link to tests and make sure it is handled correctly

* init

* try fix build

* fix build

* Fix 300391: [Mail] The numbers will become a continuous sequence after typing enter at the last line of the numbering above (#2782)

Co-authored-by: Bryan Valverde U <[email protected]>

* Pressing Tab inside a table should select all node contents of the next cell (#2764)

* normalise position

* revert

* empty cell check

* select using children

* fix tests

* fix

* Bump version to 9.10.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Julia Roldi (from Dev Box) <[email protected]>
Co-authored-by: Julia Roldi <[email protected]>
Co-authored-by: Bryan Valverde U <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andres-CT98 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants