Fix #2733 by changing the approach to announce repeated announce messages #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
flyingbee2012,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
….com/microsoft/roosterjs into u/bvalverde/fixFixAnnounceNotworking
juliaroldi
reviewed
Jul 15, 2024
| if (textToAnnounce && core.lifecycle.announceContainer) { | ||
| const { announceContainer } = core.lifecycle; | ||
| if (textToAnnounce == announceContainer.textContent) { | ||
| textToAnnounce += DOT_STRING; |
There was a problem hiding this comment.
is the dot never announced in any browser??
There was a problem hiding this comment.
No, it is only used to make the text content different, in case the announcement string is equal to the current one.
If we do not add the dot, since the text content does not change the announcement is not done.
juliaroldi
approved these changes
Jul 15, 2024
ianeli1
added a commit
that referenced
this pull request
Jul 15, 2024
* Export DefaultSanitizers to be available in roosterjs-content-model-plugins package #2739 * Fix #2741 by changing Id selectors from `#{id}` to `[id="{id}"]` (#2742) * init * Fix build * fix selection * fix * fixes * remove console.log * fix test * Fix #2734 by Setting List Metadata `applyListStyleFromLevel: true` when toggling a list (#2743) * init * Tests * add missing file * crop alternative * Fix #2733 by changing the approach to announce repeated announce messages (#2745) * init * move string to constant * bump version --------- Co-authored-by: vhuseinova-msft <[email protected]> Co-authored-by: Bryan Valverde U <[email protected]> Co-authored-by: Julia Roldi (from Dev Box) <[email protected]> Co-authored-by: Julia Roldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2733
Right now, if we are going to announce a string that was previously announced, we remove the announce container and add a new one. However this looks like it now working well. As the announcing is not done.
So we are changing the approach by adding an additional dot to the string at the end, so the string is different. Having a different text content in the announce container will make that the browser triggers an announcement to the Screen reader,
To repro:
Before:
No announcement done.
After:
Screen Reader Announce that the new list bullet is created.