Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getDOMInsertPointRect #2705

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Improve getDOMInsertPointRect #2705

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79b723f
Improve getDOMInsertPointRect
JiuqingSong Jun 14, 2024
8b2567e
fix build
JiuqingSong Jun 14, 2024
f6c08aa
Merge branch 'master' into u/jisong/getdominsertpointrect
JiuqingSong Jun 17, 2024
548adb3
Merge branch 'master' into u/jisong/getdominsertpointrect
JiuqingSong Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 25 additions & 32 deletions packages/roosterjs-content-model-dom/lib/domUtils/selection/getDOMInsertPointRect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,18 @@ import type { DOMInsertPoint, Rect } from 'roosterjs-content-model-types';
* @param pos The input DOM insert point
*/
export function getDOMInsertPointRect(doc: Document, pos: DOMInsertPoint): Rect | null {
let { node, offset } = pos;
const range = doc.createRange();

range.setStart(node, offset);

// 1) try to get rect using range.getBoundingClientRect()
let rect = normalizeRect(range.getBoundingClientRect());
return (
tryGetRectFromPos(pos, range) ?? // 1. try get from the pos directly using getBoundingClientRect or getClientRects
tryGetRectFromPos((pos = normalizeInsertPoint(pos)), range) ?? // 2. try get normalized pos, this can work when insert point is inside text node
tryGetRectFromNode(pos.node) // 3. fallback to node rect using getBoundingClientRect
);
}

if (rect) {
return rect;
}
function normalizeInsertPoint(pos: DOMInsertPoint) {
let { node, offset } = pos;

// 2) try to get rect using range.getClientRects
while (node.lastChild) {
if (offset == node.childNodes.length) {
node = node.lastChild;
Expand All @@ -31,34 +30,28 @@ export function getDOMInsertPointRect(doc: Document, pos: DOMInsertPoint): Rect
}
}

const rects = range.getClientRects && range.getClientRects();
rect = rects && rects.length == 1 ? normalizeRect(rects[0]) : null;
if (rect) {
return rect;
}
return { node, offset };
}

// 3) if node is text node, try inserting a SPAN and get the rect of SPAN for others
if (isNodeOfType(node, 'TEXT_NODE')) {
const span = node.ownerDocument.createElement('span');
function tryGetRectFromPos(pos: DOMInsertPoint, range: Range): Rect | null {
const { node, offset } = pos;

span.textContent = '\u200b';
range.insertNode(span);
rect = normalizeRect(span.getBoundingClientRect());
span.parentNode?.removeChild(span);
range.setStart(node, offset);
range.setEnd(node, offset);

if (rect) {
return rect;
}
}
const rect = normalizeRect(range.getBoundingClientRect());

// 4) try getBoundingClientRect on element
if (isNodeOfType(node, 'ELEMENT_NODE') && node.getBoundingClientRect) {
rect = normalizeRect(node.getBoundingClientRect());
if (rect) {
return rect;
} else {
const rects = range.getClientRects && range.getClientRects();

if (rect) {
return rect;
}
return rects && rects.length == 1 ? normalizeRect(rects[0]) : null;
}
}

return null;
function tryGetRectFromNode(node: Node) {
return isNodeOfType(node, 'ELEMENT_NODE') && node.getBoundingClientRect
? normalizeRect(node.getBoundingClientRect())
: null;
}
Loading