Add Image Format to getFormatState #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
JiuqingSong,
Andres-CT98,
BryanValverdeU,
flyingbee2012 and
ianeli1
JiuqingSong
reviewed
Mar 21, 2023
| @@ -59,6 +62,11 @@ export function retrieveModelFormatState( | |||
| segments.some(segment => segment.segmentType == 'Image'); | |||
|
|
|||
| isFirst = false; | |||
|
|
|||
| if (segment.segmentType === 'Image' && isFirstImage) { | |||
There was a problem hiding this comment.
A question to PM: for segments format, if the selection contains multiple different format, such as different font names, we will return undefined for that format so that user know that there are different fonts selected. Do we want to do the same for image?
| /** | ||
| * Format of image, if there is table at cursor position | ||
| */ | ||
| imageFormat?: ImageFormat; |
There was a problem hiding this comment.
For other format sub types, they are all supported by both Content model and original API. But this one is only supported by Content Model. In that case, I think we can have a sub type of FormatState in Content Model package to hold image format. So when people use original API, they will only see original formats.
What do you think?
JiuqingSong
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Image Format that includes the image border and box shadow styles to Format State.