Delete table with backspace, if whole table is selected. #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
force-pushed
the
u/juliaroldi/delete-table
branch
from
cb7db7c to
99c09e3
Compare
juliaroldi
changed the title
| keys: [Keys.BACKSPACE], | ||
| shouldHandleEvent: (event: PluginKeyboardEvent, editor: IEditor) => | ||
| cacheIsWholeTableSelected(event, editor) && | ||
| editor.isFeatureEnabled(ExperimentalFeatures.DeleteTableWithBackspace), |
There was a problem hiding this comment.
Should we check editor.isFeatureEnabled(ExperimentalFeatures.DeleteTableWithBackspace), first? Since it could take less time that trying to create a VTable and check if it is selected
JiuqingSong
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the whole table is selected, delete the table if backspaced was pressed.
