Check if there is rotate handle, before update the rotate handles #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/roosterjs-editor-plugins/lib/plugins/ImageEdit/imageEditors/Rotator.ts
Show resolved
Hide resolved
juliaroldi
commented
Feb 9, 2023
| rotateCenter, | ||
| rotateHandle | ||
| ); | ||
| if (rotateHandle && rotateCenter) { |
There was a problem hiding this comment.
@BryanValverdeU I'm doing the check for the rotateHandle and rotateCenter here. If they do not exist the updateRotateHandlePosition will not be called.
There was a problem hiding this comment.
Oh I see!
Can we also add to the null check this.editor.getVisibleViewport result? Since the ReturnType is Rect | null
There was a problem hiding this comment.
That is a good observation. I'll add it 👍🏻
There was a problem hiding this comment.
Because if we do:
const top = rotateHandleRect.top - editorRect?.top;
and editorRect is null in Rotator.tsx top could endup being NaN
BryanValverdeU
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some editing operations, the rotate handle are not rendered. Then we need to check if they exist, before we update them.