Fix for image selection #1510
Merged
Fix for image selection #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
JiuqingSong
JiuqingSong
reviewed
Jan 17, 2023
| @@ -62,6 +62,17 @@ export default class ImageSelection implements EditorPlugin { | |||
| } else if (event.rawEvent.button === mouseLeftButton) { | |||
| this.editor.select(target); | |||
| } | |||
| } else if (safeInstanceOf(target, 'HTMLElement')) { | |||
| const mouseSelection = this.editor.getSelectionRangeEx(); | |||
There was a problem hiding this comment.
Can we just let the browser handle the mouse selection?
I think you can check this in MouseDown event instead, and if target element is not current image, just unselect it, then browser should be able to handle the rest.
There was a problem hiding this comment.
I understand. I also think we need to check if the last selection is a image to not cause problems with table cell selection.
JiuqingSong
reviewed
Jan 17, 2023
Comment on lines
69
to
73
| const mouseSelection = this.editor.getSelectionRangeEx(); | ||
| if ( | ||
| !safeInstanceOf(mouseTarget, 'HTMLImageElement') && | ||
| mouseSelection && | ||
| mouseSelection.type === SelectionRangeTypes.ImageSelection |
There was a problem hiding this comment.
You just need to check if the target element is same with current selected image:
if (mouseSelection.type != Image || mouseSelection.image != event.rawEvent.target) {
select(null)
JiuqingSong
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: if ImageEditPlugin and TableCellSelection are disable, image selection does work properly.
After an image is selected, is not possible unselect it.
Fix: verify if a element was click and if the a image is selected, then if the condition is true, select the element selected.