Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix image plugin z-index calc #1500

Merged
merged 4 commits into from
Jan 12, 2023
Merged

fix image plugin z-index calc #1500

merged 4 commits into from
Jan 12, 2023

Conversation

shaipetel
Copy link
Contributor

Fixed the z-index calculation for image edit plugin.

  1. childZIndex was not being used when assigning the value to zIndex.
  2. in situations where the parent might have a lower z-index than a child element that was containing the rooster editor, the lower number was returned. Added a check to return the higher value using Math.max

@JiuqingSong
Copy link
Collaborator

@juliaroldi please take a look. Thanks

@shaipetel
Copy link
Contributor Author

Updated as per comment

@juliaroldi juliaroldi merged commit ab6bbee into microsoft:master Jan 12, 2023
@shaipetel shaipetel deleted the bug-fixes branch January 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaroldi juliaroldi juliaroldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaipetel @JiuqingSong @juliaroldi