Add a span inside of div when backspacing to previous line. #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
juliaroldi,
JiuqingSong,
Andres-CT98,
flyingbee2012 and
ianeli1
juliaroldi
approved these changes
Jan 5, 2023
JiuqingSong
reviewed
Jan 5, 2023
| this.editor?.runAsync(editor => { | ||
| const position = editor.getFocusedPosition(); | ||
| if (position && block == position.element) { | ||
| editor.ensureTypeInContainer(position, event.rawEvent); |
There was a problem hiding this comment.
If user changed to another format, will this go back to default format?
There was a problem hiding this comment.
Yes, it will go back to default format, that seem to be the same behavior when the Experimental Feature is OFF.
Only when we do backspace after 2 Enters
JiuqingSong
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a span inside of div when backspacing to previous line, in order to keep the default format in the State