Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from cloned image #1480

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

juliaroldi
Copy link
Contributor

When the image is selected it is cloned and this clone is added to the editing wrapper. Then it is necessary to remove the id in the cloned image, so the addUniqueId function do not change the original image id.

Before:
imageIdBug

After:
imageId

@juliaroldi juliaroldi marked this pull request as ready for review January 4, 2023 20:12
@juliaroldi juliaroldi mentioned this pull request Jan 4, 2023
@juliaroldi juliaroldi merged commit 4cea657 into master Jan 4, 2023
@juliaroldi juliaroldi deleted the u/juliaroldi/image-cloned-id branch January 4, 2023 20:20
@juliaroldi juliaroldi linked an issue Jan 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selectImage will overwrite the id of the image element
2 participants