Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep image wrapper under scroll container. #1466

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

juliaroldi
Copy link
Contributor

@juliaroldi juliaroldi commented Dec 13, 2022

If the image top is bigger than the editor scroll container, use clip-path css property to cut the top to avoid overlay the content above.

Before:
ViewPortBug

After:
ViewPortFix

@juliaroldi juliaroldi marked this pull request as draft December 13, 2022 18:23
@juliaroldi juliaroldi marked this pull request as ready for review January 4, 2023 17:15
@juliaroldi juliaroldi merged commit 4d4b0a0 into master Jan 4, 2023
@juliaroldi juliaroldi deleted the u/juliaroldi/image-wrapper-viewport branch January 4, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants