-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Shift-Alt-<Left|Right> to indent/outdent list #1444
Merged
+80
−31
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cb8ce96
Merge keyboard shortcut and introduce shift-alt-LR
ianeli1 00eea5d
Improve shouldHandle logic
ianeli1 9fc57b4
Update testing
ianeli1 70dd768
typo
ianeli1 7636530
Revert all changes
ianeli1 50130a2
Add into existing features
ianeli1 8994f0c
Merge branch 'master' into u/ianeli/shift-alt-lr-indent
ianeli1 7d1763e
Handle rtl
ianeli1 f5fcf12
Merge branch 'master' into u/ianeli/shift-alt-lr-indent
ianeli1 b700c42
Merge branch 'master' into u/ianeli/shift-alt-lr-indent
ianeli1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getComputedStyle() is kind of heavy. So we should only call it when we really need to.
In this case, it means when we know that it is LEFT/RIGHT key with SHIFT key pressed, and there is list, then finally we can check if it is RTL. So that this function is only called when really need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shift key check is handled by
shouldHandleIndentationEvent
, getComputedStyle doesn't get called if keycode is TAB, and this function is only called whenshouldHandleIndentationEvent
returns true, which already verifies if cursor is inside a list