Restore Ctrl+Click behavior on Firefox #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianeli1
requested review from
JiuqingSong,
Andres-CT98,
BryanValverdeU,
flyingbee2012 and
juliaroldi
Comment on lines
143
to
146
| if ( | ||
| !Browser.isFirefox && | ||
| (href = this.tryGetHref(anchor)) && | ||
| isCtrlOrMetaPressed(event.rawEvent) && | ||
| event.rawEvent.button === 0 |
There was a problem hiding this comment.
If this behavior changed overtime and Firefox is no longer opening the links by default, should we prevent the default behavior of the event if browser is Firefox in case a user with an older version and tries to open a link with Ctrl + Click?
There was a problem hiding this comment.
True, I don't think this would have any side effects so might as well preventDefault it just in case
JiuqingSong
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+Clicking an anchor with the Hyperlink plugin enabled no longer opens a new tab on Firefox. Restore behavior by removing the Firefox specific code found in Hyperlink plugin and calling
window.openalways.