Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto detect clear mode when clear format #1363

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Auto detect clear mode when clear format #1363

merged 2 commits into from
Oct 26, 2022

Conversation

JiuqingSong
Copy link
Collaborator

Fix the behavior of clear format button in roosterjs-react, auto detect clear mode.

  • If only part of a paragraph is selected, clear inline format only
  • If a full paragraph or multiple paragraphs are selected, clear both inline format and block format

@JiuqingSong JiuqingSong merged commit d708fc2 into master Oct 26, 2022
@JiuqingSong JiuqingSong deleted the u/jisong/autodetectclearformat branch October 26, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanValverdeU BryanValverdeU BryanValverdeU approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@juliaroldi juliaroldi Awaiting requested review from juliaroldi

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @BryanValverdeU