Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve image selection and table selection #1347

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Improve image selection and table selection #1347

merged 2 commits into from
Oct 20, 2022

Conversation

JiuqingSong
Copy link
Collaborator

To prepare the support for image selection in Content Model, do some refactoring for selection code. This includes:

  1. Hide cursor when image selection/table selection happens
  2. Support passing in SelectionRangeEx into editor.select()
  3. Better support image selection/table selection when do inline format and block format
  4. Better support image selection/table selection when restore selection

@JiuqingSong JiuqingSong merged commit 608b21f into master Oct 20, 2022
@JiuqingSong JiuqingSong deleted the u/jisong/selectionimprovement branch October 20, 2022 04:22
@JiuqingSong JiuqingSong mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaroldi juliaroldi juliaroldi approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@BryanValverdeU BryanValverdeU Awaiting requested review from BryanValverdeU

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @juliaroldi