Fix markdown plugin for copy/paste code #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
Andres-CT98,
BryanValverdeU,
flyingbee2012,
ianeli1 and
JiuqingSong
JiuqingSong
reviewed
Oct 11, 2022
| @@ -54,8 +54,11 @@ function cacheGetRangeForMarkdownOperation( | |||
| return false; | |||
| } | |||
|
|
|||
| const parentBlockText = textInlineElement.getParentBlock().getTextContent(); | |||
There was a problem hiding this comment.
need to add comment to explain why we do this, better with some example
…u/juliaroldi/markdown-plugin
…rosoft/roosterjs into u/juliaroldi/markdown-plugin
JiuqingSong
reviewed
Oct 12, 2022
| @@ -54,6 +54,8 @@ function cacheGetRangeForMarkdownOperation( | |||
| return false; | |||
| } | |||
|
|
|||
| //if the text is pasted, it might create a inner element inside the text element, | |||
There was a problem hiding this comment.
Is it possible to have two or more layers of DIV?
There was a problem hiding this comment.
if we have to or more layers, the markdown plugin will not work. It only work for inline elements.
JiuqingSong
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a text is pasted, it might create new inlineElement inside the current element, then to ensure the text must be converted or not, check text of the parentBlock.