[FHL] Part 1: Image Selection - selectImage core api #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u/juliaroldi/selectImageApi
…u/juliaroldi/selectImageApi
…osoft/roosterjs into u/juliaroldi/selectImageApi
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1 and
Andres-CT98
JiuqingSong
reviewed
Sep 21, 2022
| @@ -174,7 +174,6 @@ export default class PickerPlugin<T extends PickerDataProvider = PickerDataProvi | |||
|
|
|||
| case PluginEventType.KeyDown: | |||
| this.eventHandledOnKeyDown = false; | |||
|
|
|||
There was a problem hiding this comment.
no need to change here
| if (arg1 && 'rows' in arg1) { | ||
| const selection = core.api.selectTable(core, arg1, <TableSelection>arg2); | ||
| core.domEvent.tableSelectionRange = selection; | ||
|
|
There was a problem hiding this comment.
no need to change here
juliaroldi
changed the title
JiuqingSong
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new selectImage api experimental feature. With this change is possible to select an image using editor select api, also it is possible to detect when an image is selected using the getSelectionRangeEx api.
Also an interface playground was add to make it easier to debug selection inside the editor.