Add Unit Tests to Paste Plugin #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
Aug 31, 2022
...s/roosterjs-editor-plugins/lib/plugins/Paste/sourceValidations/documentContainWacElements.ts
Outdated
Show resolved
Hide resolved
|
Found issues with some Table Cell Selections tests, added this bug to track this issue. |
JiuqingSong
reviewed
Sep 1, 2022
packages/roosterjs-editor-plugins/lib/plugins/Paste/sourceValidations/constants.ts
Show resolved
Hide resolved
packages/roosterjs-editor-plugins/test/TableCellSelection/tableCellSelectionTest.ts
Outdated
Show resolved
Hide resolved
…u/bvalverde/pastePluginTests1
BryanValverdeU
requested review from
JiuqingSong,
Andres-CT98,
flyingbee2012,
ianeli1 and
juliaroldi
JiuqingSong
reviewed
Sep 6, 2022
packages/roosterjs-editor-plugins/lib/plugins/Paste/sourceValidations/getPasteSource.ts
Outdated
Show resolved
Hide resolved
JiuqingSong
reviewed
Sep 6, 2022
packages/roosterjs-editor-plugins/lib/plugins/Paste/sourceValidations/getPasteSource.ts
Outdated
Show resolved
Hide resolved
| * Represent the types of sources to handle in the Paste Plugin | ||
| */ | ||
| export const enum KnownSourceType { | ||
| WordDesktop, |
There was a problem hiding this comment.
Actually, it can be 0 here. So there is a bug.
JiuqingSong
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1233