Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix：when toggle list type,list symbol style maybe incorrect #1228

Merged
merged 13 commits into from
Aug 31, 2022
Merged

fix：when toggle list type,list symbol style maybe incorrect #1228

merged 13 commits into from
Aug 31, 2022

Conversation

JingweiXiong
Copy link
Contributor

Question

2022-08-31.11.08.23.mov

In some case such as li>b>text, list symbol style is incorrect

After resolved

2022-08-31.11.07.45.mov

Thanks.

@JiuqingSong
Copy link
Collaborator

@juliaroldi @BryanValverdeU would you please review this change? Thanks.

@BryanValverdeU BryanValverdeU merged commit 422f650 into microsoft:master Aug 31, 2022
@juliaroldi
Copy link
Contributor

@JingweiXiong Hey, I tried you change, at least for me, the feature does not work, if the first element does not have any change in the styles.
TestingListgif

@JiuqingSong
Copy link
Collaborator

@JingweiXiong Hey, I tried you change, at least for me, the feature does not work, if the first element does not have any change in the styles. TestingListgif TestingListgif

@juliaroldi please feel free to revert if you feel like the change not working well. Thanks.

@juliaroldi
Copy link
Contributor

@JingweiXiong
TestingListgif2

juliaroldi added a commit that referenced this pull request Aug 31, 2022
@juliaroldi
Revert "fix：when toggle list type,list symbol style maybe incorrect (#…
6d9b9d5 
…1228)"

This reverts commit 422f650.
@juliaroldi juliaroldi mentioned this pull request Aug 31, 2022
Merged
@BryanValverdeU BryanValverdeU mentioned this pull request Aug 31, 2022
Merged
BryanValverdeU added a commit that referenced this pull request Aug 31, 2022
@BryanValverdeU
Add again fix：when toggle list type,list symbol style maybe incorrect #…
4fda4c2 
…1228 (#1232)

* Revert "Merge pull request #1230 from microsoft/revert-1228-list-symbol-style"

This reverts commit cc0d7c1, reversing
changes made to 422f650.

* fix
@JingweiXiong
Copy link
Contributor Author

@juliaroldi @JiuqingSong Sorry. It's my problem. I moved here after my project was test successful, but i miss VListItem.ts.

@juliaroldi
Copy link
Contributor

@juliaroldi @JiuqingSong Sorry. It's my problem. I moved here after my project was test successful, but i miss VListItem.ts.

Hey @JingweiXiong, that is not a problem. @BryanValverdeU fixed the missing code and we already merged your fix into our codebase. Thanks for contribute to RoosterJS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanValverdeU BryanValverdeU BryanValverdeU approved these changes

@juliaroldi juliaroldi Awaiting requested review from juliaroldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JingweiXiong @JiuqingSong @juliaroldi @BryanValverdeU