Allow setting custom classname to Watermark entities for easy querying #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianeli1
requested review from
JiuqingSong,
Andres-CT98,
BryanValverdeU,
flyingbee2012 and
juliaroldi
JiuqingSong
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by #1079, there's no easy way to query for watermark elements without reverse-engineering Rooster a little.
Given that the current class name (
_EId_WATERMARK_WRAPPER) is also used for the entity system, overriding is not an option. As such, an optional extra class can be added to these entities specifically. This is done when constructing the Watermark plugin by adding astringas a third parameter.