fix: imageEditPlugin cause content bounce and original image size change #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
approved these changes
Aug 12, 2022
Merged
|
I found a regression from this change:
I have made a change and it is included in this PR #1175 |
ok, thanks. |
JiuqingSong
added a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question 1
When start image edit cause content bounce because change the content verticalAlign.
2022-08-12.1.05.30.mov
Question 2
When click image start edit, but don't resize. After blur, the original image may be change its size because set initial when not wasResized
2022-08-12.1.07.17.mov
Fixed
Fixed in my code, thanks.