Fix a regression in TableCellSelection (#1357)

* Fix a regression in Table Selection * Handle Home and End key
microsoft · Oct 24, 2022 · b9630a6 · b9630a6
1 parent 0fcb359
commit b9630a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/roosterjs-editor-plugins/lib/plugins/TableCellSelection/TableCellSelection.ts b/packages/roosterjs-editor-plugins/lib/plugins/TableCellSelection/TableCellSelection.ts
@@ -22,6 +22,7 @@ import {
     VTable,
     Position,
     contains,
+    isCtrlOrMetaPressed,
 } from 'roosterjs-editor-dom';
 
 const TABLE_CELL_SELECTOR = 'td,th';
@@ -210,7 +211,10 @@ export default class TableCellSelection implements EditorPlugin {
                     this.tableSelection = false;
                 }
             });
-        } else if (this.editor.getSelectionRangeEx()?.type == SelectionRangeTypes.TableSelection) {
+        } else if (
+            this.editor.getSelectionRangeEx()?.type == SelectionRangeTypes.TableSelection &&
+            (!isCtrlOrMetaPressed(event.rawEvent) || which == Keys.HOME || which == Keys.END)
+        ) {
             this.editor.select(null);
         }
     }

diff --git a/packages/roosterjs-editor-types/lib/enum/Keys.ts b/packages/roosterjs-editor-types/lib/enum/Keys.ts
@@ -12,6 +12,8 @@ export const enum Keys {
     ESCAPE = 27,
     SPACE = 32,
     PAGEUP = 33,
+    END = 35,
+    HOME = 36,
     LEFT = 37,
     UP = 38,
     RIGHT = 39,