Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): address pnpm issues #2806

Merged
merged 2 commits into from
Nov 9, 2023
Merged

test(cli): address pnpm issues #2806

merged 2 commits into from
Nov 9, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 9, 2023

Description

Address pnpm issues.

Test plan

Enable pnpm mode:

diff --git a/.yarnrc.yml b/.yarnrc.yml
index 1bf9d579..6771046f 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -7,7 +7,7 @@ logFilters:
     level: discard
   - code: YN0013 # X can't be found in the cache and will be fetched from the remote registry
     level: discard
-nodeLinker: node-modules
+nodeLinker: pnpm
 npmRegistryServer: "https://registry.npmjs.org"
 packageExtensions:
   "@fluentui/utilities@*":

Run:

yarn test

@tido64 tido64 requested a review from acoates-ms November 9, 2023 09:29
@github-actions github-actions bot added the feature: cli This is related to CLI label Nov 9, 2023
@tido64 tido64 merged commit f4bfda6 into main Nov 9, 2023
@tido64 tido64 deleted the tido/pnpm/fix-cli branch November 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: cli This is related to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants