Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-metro-react-native): help Babel resolve @babel/plugin-transform-classes #2791

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 6, 2023

Description

Help Babel find @babel/plugin-transform-classes in pnpm setups

Test plan

Enable pnpm mode:

diff --git a/.yarnrc.yml b/.yarnrc.yml
index f59a253e..b2cfdf1f 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -7,7 +7,7 @@ logFilters:
     level: discard
   - code: YN0013 # X can't be found in the cache and will be fetched from the remote registry
     level: discard
-nodeLinker: node-modules
+nodeLinker: pnpm
 npmRegistryServer: "https://registry.npmjs.org"
 packageExtensions:
   "@fluentui/utilities@*":

Run:

yarn
cd packages/babel-preset-metro-react-native
yarn test

@tido64 tido64 requested a review from acoates-ms November 6, 2023 12:54
@github-actions github-actions bot added the feature: metro This is related to Metro label Nov 6, 2023
@tido64 tido64 force-pushed the tido/fix-babel-preset-metro-react-native-tests branch from f427c3e to 1292266 Compare November 6, 2023 15:47
@tido64 tido64 merged commit 95703e4 into main Nov 6, 2023
@tido64 tido64 deleted the tido/fix-babel-preset-metro-react-native-tests branch November 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: metro This is related to Metro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants