Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross compile builds for s390x and ppc on azure ci #13

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

Rohan-Shinde-98
Copy link
Contributor

Previously ppc and s390x binaries were released via Travis-CI however with the recent move to azure pipelines, the binaries are not published.
This PR is in reference to #2 (comment) to add a cross-compiled build for ppc & s390x binary on azure ci.

Attaching build pipeline status from my forked repo.
https://dev.azure.com/RohanShinde/ripgrep-prebuilt/_build/results?buildId=77&view=results

@ghost
Copy link

ghost commented Oct 14, 2021

CLA assistant check
All CLA requirements met.

@svghadi
Copy link
Contributor

svghadi commented Oct 14, 2021

Hi @roblourens, please have a look.

@roblourens
Copy link
Member

Thanks! Yeah, we aren't going to use Travis anymore. First glance looks fine, let me take another look later

@ghatwala
Copy link

@roblourens - any updates from your second look/review ? does this look good to now re-enable power+s390x binaries via azure pipeline ?

@roblourens roblourens merged commit 5e6bb19 into microsoft:main Oct 20, 2021
@Rohan-Shinde-98
Copy link
Contributor Author

Rohan-Shinde-98 commented Oct 26, 2021

Hi @roblourens after merging PR, the build pipeline is getting canceled for all the Linux jobs.
Looks like the cause is ubuntu16.04 image is not available as it is deprecated, also the azure pipeline is giving the same warning as ##[warning]An image label with the label ubuntu-16.04 does not exist.

Any thoughts on this?

Below is the attached screenshot
image

@roblourens
Copy link
Member

Fixed, thanks

imphil added a commit to imphil/vscode-ripgrep that referenced this pull request Dec 23, 2021
The previously used v13.0.0-2 build was missing ppc64le (PowerPC)
and s390 binaries due to a switch from Travis to Azure Pipelines.
v13.0.0-4 includes those platforms again.

See also microsoft/ripgrep-prebuilt#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants