Config spec updates, more logging #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
requested review from
analogrelay,
halter73,
davidfowl,
stephentoub and
davidni
stephentoub
reviewed
Mar 26, 2020
| @@ -104,6 +104,15 @@ private void UpdateRuntimeBackends(DynamicConfigRoot config) | |||
| currentBackendConfig.HealthCheckOptions.Port != newConfig.HealthCheckOptions.Port || | |||
| currentBackendConfig.HealthCheckOptions.Path != newConfig.HealthCheckOptions.Path) | |||
| { | |||
| if (currentBackendConfig == null) | |||
| { | |||
| _logger.LogDebug("Backend {backendId} has been added.", configBackend.BackendId); | |||
There was a problem hiding this comment.
Just to confirm, the {} syntax without the $ is actually using an ASP.NET Core-specific scheme for naming the holes in the format?
There was a problem hiding this comment.
Right, logging will fill that in.
stephentoub
approved these changes
Mar 26, 2020
davidni
approved these changes
Mar 26, 2020
halter73
reviewed
Mar 26, 2020
halter73
approved these changes
Mar 26, 2020
davidfowl
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental updates to the config spec.