-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Kestrel response header encoding #1346
Comments
hi Chris @Tratcher / @MihaZupan / @karelz .. i'm trying to use yarp and facing this encoding issue due to a downstream system returning non-ASCII chars in the response header. since I don't have control over the downstream system, I am trying to see how we can be more tolerant at yarp's end. now that aspnetcore/ I was hoping this documentation update issue might help make that clear. even if someone can give a TL;DR on how to achieve this without this documentation-update-issue being resolved, it'd be great. |
You don't need to do anything YARP specific, you configure the Kestrel options directly in your proxy app. |
ah sorry. thanks @Tratcher. i'll try something via appSettings.. or even code like the below. builder.WebHost.ConfigureKestrel(serverOptions =>
{
serverOptions.ResponseHeaderEncodingSelector = _ => System.Text.Encoding.Unicode;
}); |
…arded Requests (#2254) * add support for ResponseHeaderEncoding in HttpClientConfig (progress commit) * fix ConfigValidatorTests * fix ConfigurationConfigProviderTests by updating setup config to set ResponseHeaderEncoding appropriately * fix bug in suggested interface (probably an old name for the instance?) * update documentation (also closes issue Document Kestrel response header encoding #1346) * ..and finally, validate if ForwarderHttpClientFactory leverages the HttpClientConfig.ResponseHeaderEncoding appropriately * oopsie daisy * simplify documentation by leveraging XML comments for code * re-add removed section that educates consumers about ensuring to set server (with e.g. Kestrel) options for header encoding to match SocketsHttpHandler's header encoding options * Apply suggestions from code review * Replace links with code references --------- Co-authored-by: Miha Zupan <[email protected]>
From #1055:
Document Kestrel response header encoding (dotnet/aspnetcore#33776) here.
The text was updated successfully, but these errors were encountered: