Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update values.yaml path for prometheus #757

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Sep 19, 2024

Description

  1. fix broken path for Prometheus values.yaml path (Helm deployment)
  2. clean-up the bullet points numbering

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi self-assigned this Sep 19, 2024
@SRodi SRodi requested a review from a team as a code owner September 19, 2024 09:11
@SRodi SRodi requested review from mereta and BeegiiK September 19, 2024 09:11
@nddq
Copy link
Contributor

nddq commented Sep 20, 2024

@SRodi can you sign your commits?

@nddq nddq enabled auto-merge September 20, 2024 16:25
@SRodi
Copy link
Member Author

SRodi commented Sep 20, 2024

@SRodi can you sign your commits?

@nddq Sorry for the oversight, done now. Would it be worth considering to enforce the disallow of unsigned commits at repo level? I see this issue happening with other contributors too.

@nddq nddq added this pull request to the merge queue Sep 20, 2024
Merged via the queue into microsoft:main with commit 10a1bc5 Sep 20, 2024
22 checks passed
@SRodi SRodi deleted the chore/docs branch September 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants