Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add clarity to telemetry enablement #69

Merged
merged 4 commits into from
Mar 19, 2024
Merged

chore: add clarity to telemetry enablement #69

merged 4 commits into from
Mar 19, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 18, 2024

Adding docs and checks for better clarify where and how telemetry is enabled. Also fix a bug where TrackPanic is invoke even though telemetry is not enabled.

@nddq nddq added the type/enhancement New feature or request label Mar 18, 2024
@nddq nddq self-assigned this Mar 18, 2024
@nddq nddq requested a review from a team as a code owner March 18, 2024 21:16
@nddq nddq force-pushed the nddq/telemetry branch 2 times, most recently from 934eef4 to 9bb4002 Compare March 18, 2024 21:32
@nddq nddq force-pushed the nddq/telemetry branch 3 times, most recently from 3c20543 to 0ece201 Compare March 19, 2024 16:04
@nddq nddq requested a review from rbtr March 19, 2024 16:18
@nddq nddq merged commit 7eedecf into main Mar 19, 2024
18 checks passed
@nddq nddq deleted the nddq/telemetry branch March 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants