Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove template variable args from oci install instructions #168

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

rbtr
Copy link
Collaborator

@rbtr rbtr commented Mar 28, 2024

Removes leftover chart args from the Make instructions that shouldn't be in the quickstart OCI instructions.

@rbtr rbtr added area/documentation Improvements or additions to documentation type/fix Fixes something labels Mar 28, 2024
@rbtr rbtr requested a review from a team as a code owner March 28, 2024 17:22
Copy link
Contributor

@peterj peterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were faster than me :)

@rbtr
Copy link
Collaborator Author

rbtr commented Mar 28, 2024

@peterj you were busy streaming 😉

@rbtr rbtr enabled auto-merge (squash) March 28, 2024 21:45
@rbtr rbtr added the priority/2 P2 label Mar 28, 2024
@rbtr rbtr merged commit b7ac4fd into microsoft:main Mar 29, 2024
15 checks passed
@rbtr rbtr deleted the fix/chart-args branch March 29, 2024 15:47
hainenber pushed a commit to hainenber/retina that referenced this pull request Apr 4, 2024
…rosoft#168)

Removes leftover chart args from the Make instructions that shouldn't be
in the quickstart OCI instructions.

Signed-off-by: Evan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation priority/2 P2 type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants