Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goreleaser): update ldflags for building Retina CLI #1108

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Dec 5, 2024

Description

When building the Retina CLI locally, kubectl retina version showed up normally. After digging around, I found that we haven't update goreleaser with the latest ldflags.

Related Issue

Fix #1013

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq added type/fix Fixes something area/infra Test, Release, or CI Infrastructure labels Dec 5, 2024
@nddq nddq requested a review from rbtr December 5, 2024 21:11
@nddq nddq self-assigned this Dec 5, 2024
@nddq nddq requested a review from a team as a code owner December 5, 2024 21:11
@nddq nddq requested a review from ibezrukavyi December 5, 2024 21:11
@nddq nddq enabled auto-merge December 5, 2024 21:19
@nddq nddq added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@nddq nddq added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit b7316a1 Dec 5, 2024
27 checks passed
@nddq nddq deleted the nddq/fixGoreleaser branch December 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Test, Release, or CI Infrastructure type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retina CLI version command shows only a blank line
2 participants