-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ct-metrics): add initial conntrack metrics for Prometheus #1057
base: main
Are you sure you want to change the base?
Conversation
35fee01
to
c9b9e30
Compare
Did we think though around scalability, performance and stability when adding these metrics? Do we have any concerns? Do we have numbers to back this up? |
c9b9e30
to
7aa9dbf
Compare
@@ -140,6 +140,26 @@ func InitializeMetrics() { | |||
dnsResponseCounterDescription, | |||
) | |||
|
|||
// Conntrack Metrics | |||
ConntrackPacketsCounter = exporter.CreatePrometheusGaugeVecForMetric( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you find a way to integrate these into Hubble metrics as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7aa9dbf
to
105f236
Compare
Description
Create initial metrics for conntrack:
Related Issue
#806
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
This example shows a long-lived TCP connection between client
src_ip="10.244.0..230
and server10.244.1.85
This example shows the
bytes_count_per_connection
wheredst_ip=10.244.0.113
which is the pod IP formetrics-server
on one of the cluster nodes.(WIP) Here is some initial work on Hubble metrics
Considerations
The number of time series increases overtime based on number of new connections in the cluster - the count of time series is the same for both
packets_count_per_connection
andbytes_count_per_connection
metrics since both use the same labels.Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.