Add node level metric for no VFPCounters #933
Assignees
Labels
area/metrics
area/windows
good first issue
Good for newcomers
help wanted
Extra attention is needed
lang/go
The Go Programming Language
priority/1
P1
type/enhancement
New feature or request
Milestone
Comments
anubhabMajumdar
added
area/metrics
area/windows
good first issue
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 14, 2025
…ug (#958) # Description Add node level metric for no VFPCounters. Tested the new metric works by calling the metrics endpoint inside the node of the windows retina pod: ``` curl.exe http://10.224.0.9:10093/metrics ... # HELP networkobservability_windows_hns_stats Include many different metrics from packets sent/received to closed connections # TYPE networkobservability_windows_hns_stats gauge networkobservability_windows_hns_stats{direction="win_packets_recv_count"} 12 networkobservability_windows_hns_stats{direction="win_packets_sent_count"} 84 # HELP networkobservability_windows_vfp_stats Include many different metrics from packets sent/received to closed connections # TYPE networkobservability_windows_vfp_stats gauge networkobservability_windows_vfp_stats{state="uninitialized"} 36 ``` ## Related Issue #933 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes The metric was generated as it brought outside the conditional statement for testing purposes only, i.e. metric can be compiled and incremented. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, if
VFPCountersis zero, we log a error/warn message. Instead, this should be node level metric.Ref: https://github.com/microsoft/retina/blame/ecdabdbf715fc8d2b180c7c6ebf858ad18d08207/pkg/plugin/windows/hnsstats/hnsstats_windows.go#L169
Describe the solution you'd like
A node level metric.
The text was updated successfully, but these errors were encountered: