Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerations to operator and agent to the Hubble chart #1112

Closed
roberthstrand opened this issue Dec 8, 2024 · 0 comments · Fixed by #1113
Closed

Add tolerations to operator and agent to the Hubble chart #1112

roberthstrand opened this issue Dec 8, 2024 · 0 comments · Fixed by #1113

Comments

@roberthstrand
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Running Retina in a very restricted environment calls for having a way to define tolerations. This was in the legacy helm chart as a single value, but the Hubble helm chart does not have this on the operator or agent sections of the values file.

Describe the solution you'd like
When deploying the new Hubble chart, I want to be able to set tolerations for all components.

Describe alternatives you've considered
Either have one tolerations value, like the original chart, but I will rather have this on a per component basis.

Additional context
I have developed a fix for this, tested and ready for a pull requests.
@roberthstrand roberthstrand mentioned this issue Dec 8, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
@roberthstrand
feat: add tolerations to values and templates (#1113)
ef96eea 
# Description

This pull request adds a list called `tolerations` to the operator and
agent sections of the values file, and implement them into the
templates.

## Related Issue

This is a pull request to close #1112, as agreed upon in the Office
Hours meeting, Friday the 6th.

## Checklist

- [x] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

Signed-off-by: Roberth Strand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Retina Triage Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tolerations to values and templates roberthstrand/microsoft-retina
1 participant
@roberthstrand