Fix issues in c,cpp,no-std binding examples #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use regorus_ffi in target_link_libraries instead of regorus-ffi. Something seems to have changed in corrosion-rs to need this. - Workaround for cmake issue where FFI header may not be generated in time Signed-off-by: Anand Krishnamoorthi <[email protected]>
anakrish
force-pushed
the
fix-workflow-name
branch
from
018aaa8
to
77c69c6
Compare
anakrish
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of a sudden these fail due to
regorus.hnot being available. Smething has likely changed in corrosion-rs to cause the main to be compiled before the headers are generated. It could also be a latent issue.The fix for the former is to ensure in the workflow file that the header is generated by explicitly compiling the ffi binding.
The fix for the latter is to use
regorus_ffiin target_link_libraries instead ofregorus-ffi.