Fix Crash when Logbox shown on pre-19H1 #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActualHeight was added to UIElement in 19H1, but is being used in native code for Logbox/legacy redbox. This will also cause integration tests to crash on redbox, since they're running on debug build on Windows Server 2019. Replace usages with ActualHeight/ActualWidth. Initial thoughts are to not backport this, since it's dev only and has existed for a couple of versions.
dannyvv
approved these changes
Oct 20, 2020
acoates-ms
approved these changes
Oct 20, 2020
acoates-ms
added a commit
that referenced
this pull request
Oct 21, 2020
* Move UIManager to NM2 infra * formatting * Update x86 def file * Change files * Add win32 as a valid platform to platformcolorexample.win32 (#6255) * Fix switch events (#6264) * Switch was generating spurious events which could result on two events (on/off) being sent before the first event was fully handled * Change files * Implement code review recommendations * Make sure that m_updating is not left in wrong state if toggle switch null * Address further review comment * Update Chakra JSI implementation (#5710) * Update Chakra JSI implementation * Change files * Move new Chakra JSI Universal tests into MS.RN.ComponentTests * Address PR feedback * Address PR feedback * Fix x64 release compilation error * Add CreateRuntime and DisposeRuntime * Confirm to JSI API changes * Remove JSI_SourcePath * Allow having empty strings as JS object property name * applying package updates ***NO_CI*** * Bump @types/react-native from 0.63.25 to 0.63.26 (#6273) * Bump beachball from 1.37.0 to 1.38.0 (#6276) * Bump @types/jest from 26.0.14 to 26.0.15 (#6274) * Drop Issue Requirement from Override Manifest Schema Validation (#6263) * Drop Issue Requirement from Override Manifest Schema Validation Most types of overrrides require an issue number. This is done on the schema level, and is done incosistently per-type, where some allow no issues or LEGACY_FIXME, where others allow none. This was done to add barriers to forking, but ends up being a bit to broad/heavy-handed, and the differences between requirements of override types is confusing. This changes makes the schema uniform, dropping the special LEGACY_FIXME issue and universally allowing missing issues. To guide engineers to the right path, we still do require issues depending on types in the override prompt, but these can be altered manually. * Change files * Update copies to undefined issue during manifest generation * serializeBase cleanup * Bump babel-jest from 26.5.2 to 26.6.0 (#6272) * Add yargs-parser and node-fetch resolutions to pass component governance (#6270) Closes #6266 Closes #6267 * Fix Crash when Logbox shown on pre-19H1 (#6283) * Fix Crash when Logbox shown on pre-19H1 ActualHeight was added to UIElement in 19H1, but is being used in native code for Logbox/legacy redbox. This will also cause integration tests to crash on redbox, since they're running on debug build on Windows Server 2019. Replace usages with ActualHeight/ActualWidth. Initial thoughts are to not backport this, since it's dev only and has existed for a couple of versions. * Change files * Fix callbacks * formatting * Logging test fires an error, which shouldnt fail the integration tests * TextInput and ScrollViewer use some non-standard event names that I missed Co-authored-by: Patrick Boyd <[email protected]> Co-authored-by: gillpeacegood <[email protected]> Co-authored-by: Vladimir Morozov <[email protected]> Co-authored-by: React-Native-Windows Bot <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Nick Gerleman <[email protected]> Co-authored-by: Jon Thysell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActualSize was added to UIElement in 19H1, but is being used in native code for Logbox/legacy redbox. This will also cause integration tests to crash on redbox, since they're running on debug build on Windows Server 2019.
Replace usages with ActualHeight/ActualWidth.
Initial thoughts are to not backport this, since it's dev only and has existed for a couple of versions.
Microsoft Reviewers: Open in CodeFlow